Files
stackpilot/backend/tests/conftest.py
T
menzeljandClaude Opus 5.5 d6cebb3371
CI / check (push) Successful in 4m9s
CI / build-and-push (push) Failing after 16m10s
Fix what a review of the whole app found, end to end (0.67.1)
A pass over every feature against a real Docker daemon, then clicking
through the UI as admin and read-only user, on a desktop and a phone.

Security. /ws/deploy ran compose up for the read-only role; it is
admin-only now. A container's inspect view, a stack's compose file
(POSTGRES_PASSWORD: hunter2) and the viewer's .env tab no longer show
credentials to that role. Git branch and URL values that git would read
as options (-x, ext::) are refused. SFTP host keys are checked: pinned
on first use or entered by hand (key line or SHA256 fingerprint), a
different key is refused before the password is sent. A backup name
from the API can no longer reach outside the destination folder. The
file browser refuses to move or rename a browse root, as delete did.

Docker lifecycle. Closing the deploy console released the stack lock
while compose was still running and logged rc=None as success; deploys
and updates are now background runs that hold the lock to the end,
report the real exit code and can be re-attached to. Every closed log
view left a `compose logs -f` behind. A dozen open tabs exhausted the
default thread pool and hung the API; event and exec streams have their
own threads. Auto-update and the update endpoint ignored failed pulls.
A deleted git stack was recreated and started by the next webhook or
poll; deleting a stack now drops its git source, auto-update policy and
schedule entries. Deleting no longer walks into mounted shares, is
refused while a backup runs, and removes the containers even when the
compose file is broken. Stack folders compose has to normalise
(Nextcloud -> nextcloud) work everywhere and group correctly on the
volumes, networks and images pages.

Detection. Host port conflicts read the container's own network
namespace; /proc/1/net is read instead. Images referenced as docker.io/…
were never update-checked; local builds no longer report "needs
credentials". NVIDIA GPUs are read from the driver's procfs. The backup
dialog's "path mismatch" warning came from mountinfo's filesystem-relative
root and fired for any stacks folder on its own disk, ZFS dataset or
btrfs subvolume; the host path now comes from Docker's mounts.

Backups and destinations. The download ignored the folder/volume
selection (axios sent binds[]). Restoring under a new name kept the old
one. A report header past nginx's buffer turned a good backup into a
502. SFTP/S3 errors were bare 500s and "Test" did not try to write.
A destination used by a schedule could be deleted. Backup file names
are in the schedule's or the browser's time zone instead of UTC.

Editor and converter. `docker run` conversion produced invalid compose
for --network host, named volumes and -dit; --gpus and --mount were
dropped; a multi-line command pasted into the one-line field became
`image: ' '` (now a textarea, and flattened continuations are read).
Validation failed for env_file stacks. The editor overwrote unsaved
edits on every container event, lost them on a stray click (now asks),
threw when closing the diff, and its helper panel listed the starter
service "app" for every existing stack. Monaco is bundled instead of
loaded from jsdelivr, so the editor works offline (and monaco-editor
0.57 drops the dompurify advisory; axios and react-router updated).

UI. All times were two hours off: offset-less UTC from SQLite was read
as local time, and "next run" always said "just now". A token refresh
mid-session duplicated deploys, reset terminals and doubled logs. A
backend restart (update, self-update) signed everyone out on reload; the
page now waits for it. The editor was unusable on a phone, tables and
tabs overflowed, dialog text was black on the dark theme, and the file
browser opened on an error with the default roots. Read-only users get
"Admin only" pages instead of 403s; in-use networks offer no delete;
"Scan all" covers StackPilot's own stacks only and runs in the
background instead of timing out at 600s.

Deployment. nginx passes the port in Host (the OIDC redirect URI lost
:5009) and keeps an outer proxy's X-Forwarded-Proto. The frontend waits
for a healthy backend (healthcheck probes every 2s while starting). The
frontend image builds with npm ci. Secrets are 0644 in a 0700 folder so
non-root containers can read them; existing files are fixed at startup.
The test suite no longer starts real containers on a host with Docker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fx7gcuy8d6nPd95g43rGHu
2026-10-15 13:51:26 +02:00

151 lines
4.9 KiB
Python

"""Shared fixtures.
Two things have to happen before anything from the backend is imported, which
is why they sit at module level rather than in a fixture:
* ``DATA_DIR`` / ``STACKS_DIR`` must point at a throwaway directory — ``config``
and ``database`` read them at import time (the SQLite path is computed then),
so a fixture would be too late and the suite would scribble on a real install.
* ``SECRET_KEY`` must be set, or ``config._ensure_secret`` would generate one
and persist it into the temp data dir. Harmless, but a fixed key keeps token
fixtures reproducible.
The app is driven through ``TestClient`` **without** entering it as a context
manager, which deliberately skips the lifespan: no background update/schedule
loops, and no Docker connection. Tests that need database tables depend on the
``db`` fixture, which runs ``init_db()`` once per session.
"""
from __future__ import annotations
import os
import sys
import tempfile
from pathlib import Path
import pytest
_TMP = tempfile.mkdtemp(prefix="stackpilot-tests-")
os.environ["DATA_DIR"] = os.path.join(_TMP, "data")
os.environ["STACKS_DIR"] = os.path.join(_TMP, "stacks")
os.environ["SECRET_KEY"] = "test-secret-key-not-used-anywhere-real"
os.environ["ALLOWED_BROWSE_ROOTS"] = "/mnt,/media,/srv,/opt,/home"
os.environ["HOST_ROOT_PREFIX"] = ""
# No Docker, even where there is one. The suite is written for a host without a
# daemon, and where one *is* reachable — a dev box, or the CI runner, which gets
# the host's socket — tests that go "far enough in" really ran `compose up` and
# left containers running on that host after every run. docker-py reads
# DOCKER_SOCKET, the docker CLI (compose) reads DOCKER_HOST; both point nowhere.
_NO_DOCKER = os.path.join(_TMP, "no-docker.sock")
os.environ["DOCKER_SOCKET"] = _NO_DOCKER
os.environ["DOCKER_HOST"] = f"unix://{_NO_DOCKER}"
# The backend runs from its own root at runtime (`uvicorn main:app` with
# /app as the workdir), so make the same layout importable here.
BACKEND_ROOT = Path(__file__).resolve().parent.parent
sys.path.insert(0, str(BACKEND_ROOT))
os.makedirs(os.environ["DATA_DIR"], exist_ok=True)
os.makedirs(os.environ["STACKS_DIR"], exist_ok=True)
@pytest.fixture(scope="session")
def db():
"""Create the schema in the throwaway SQLite file. Idempotent."""
from database import engine, init_db
init_db()
return engine
@pytest.fixture(scope="session")
def app(db):
from main import app as fastapi_app
return fastapi_app
@pytest.fixture(scope="session")
def users(app):
"""One admin and one plain user, created directly in the DB.
Returns ``(admin, user)`` as detached copies — the ORM objects themselves
would be bound to a closed session.
"""
from sqlmodel import Session, select
import auth as auth_mod
from database import engine
from models.user import User
with Session(engine) as session:
for username, role in (("test-admin", "admin"), ("test-user", "user")):
if not session.exec(select(User).where(User.username == username)).first():
session.add(
User(
username=username,
hashed_password=auth_mod.hash_password("pw-" + username),
role=role,
)
)
session.commit()
admin = session.exec(select(User).where(User.username == "test-admin")).one()
user = session.exec(select(User).where(User.username == "test-user")).one()
session.expunge_all()
return admin, user
@pytest.fixture(scope="session")
def admin_token(users):
import auth as auth_mod
return auth_mod.create_access_token(users[0])
@pytest.fixture(scope="session")
def user_token(users):
import auth as auth_mod
return auth_mod.create_access_token(users[1])
@pytest.fixture(scope="session")
def client(app):
from starlette.testclient import TestClient
# No `with`: skips lifespan, so no background loops and no Docker.
return TestClient(app, raise_server_exceptions=False)
@pytest.fixture
def as_admin(client, admin_token):
return _AuthedClient(client, admin_token)
@pytest.fixture
def as_user(client, user_token):
return _AuthedClient(client, user_token)
class _AuthedClient:
"""Thin wrapper that attaches a bearer token to every request."""
def __init__(self, client, token: str):
self._client = client
self._headers = {"Authorization": f"Bearer {token}"}
def request(self, method: str, url: str, **kwargs):
headers = {**self._headers, **kwargs.pop("headers", {})}
return self._client.request(method, url, headers=headers, **kwargs)
def get(self, url, **kw):
return self.request("GET", url, **kw)
def post(self, url, **kw):
return self.request("POST", url, **kw)
def put(self, url, **kw):
return self.request("PUT", url, **kw)
def delete(self, url, **kw):
return self.request("DELETE", url, **kw)