menzeljandClaude Opus 5.5
d6cebb3371
A pass over every feature against a real Docker daemon, then clicking through the UI as admin and read-only user, on a desktop and a phone. Security. /ws/deploy ran compose up for the read-only role; it is admin-only now. A container's inspect view, a stack's compose file (POSTGRES_PASSWORD: hunter2) and the viewer's .env tab no longer show credentials to that role. Git branch and URL values that git would read as options (-x, ext::) are refused. SFTP host keys are checked: pinned on first use or entered by hand (key line or SHA256 fingerprint), a different key is refused before the password is sent. A backup name from the API can no longer reach outside the destination folder. The file browser refuses to move or rename a browse root, as delete did. Docker lifecycle. Closing the deploy console released the stack lock while compose was still running and logged rc=None as success; deploys and updates are now background runs that hold the lock to the end, report the real exit code and can be re-attached to. Every closed log view left a `compose logs -f` behind. A dozen open tabs exhausted the default thread pool and hung the API; event and exec streams have their own threads. Auto-update and the update endpoint ignored failed pulls. A deleted git stack was recreated and started by the next webhook or poll; deleting a stack now drops its git source, auto-update policy and schedule entries. Deleting no longer walks into mounted shares, is refused while a backup runs, and removes the containers even when the compose file is broken. Stack folders compose has to normalise (Nextcloud -> nextcloud) work everywhere and group correctly on the volumes, networks and images pages. Detection. Host port conflicts read the container's own network namespace; /proc/1/net is read instead. Images referenced as docker.io/… were never update-checked; local builds no longer report "needs credentials". NVIDIA GPUs are read from the driver's procfs. The backup dialog's "path mismatch" warning came from mountinfo's filesystem-relative root and fired for any stacks folder on its own disk, ZFS dataset or btrfs subvolume; the host path now comes from Docker's mounts. Backups and destinations. The download ignored the folder/volume selection (axios sent binds[]). Restoring under a new name kept the old one. A report header past nginx's buffer turned a good backup into a 502. SFTP/S3 errors were bare 500s and "Test" did not try to write. A destination used by a schedule could be deleted. Backup file names are in the schedule's or the browser's time zone instead of UTC. Editor and converter. `docker run` conversion produced invalid compose for --network host, named volumes and -dit; --gpus and --mount were dropped; a multi-line command pasted into the one-line field became `image: ' '` (now a textarea, and flattened continuations are read). Validation failed for env_file stacks. The editor overwrote unsaved edits on every container event, lost them on a stray click (now asks), threw when closing the diff, and its helper panel listed the starter service "app" for every existing stack. Monaco is bundled instead of loaded from jsdelivr, so the editor works offline (and monaco-editor 0.57 drops the dompurify advisory; axios and react-router updated). UI. All times were two hours off: offset-less UTC from SQLite was read as local time, and "next run" always said "just now". A token refresh mid-session duplicated deploys, reset terminals and doubled logs. A backend restart (update, self-update) signed everyone out on reload; the page now waits for it. The editor was unusable on a phone, tables and tabs overflowed, dialog text was black on the dark theme, and the file browser opened on an error with the default roots. Read-only users get "Admin only" pages instead of 403s; in-use networks offer no delete; "Scan all" covers StackPilot's own stacks only and runs in the background instead of timing out at 600s. Deployment. nginx passes the port in Host (the OIDC redirect URI lost :5009) and keeps an outer proxy's X-Forwarded-Proto. The frontend waits for a healthy backend (healthcheck probes every 2s while starting). The frontend image builds with npm ci. Secrets are 0644 in a 0700 folder so non-root containers can read them; existing files are fixed at startup. The test suite no longer starts real containers on a host with Docker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fx7gcuy8d6nPd95g43rGHu
83 lines
2.8 KiB
Python
83 lines
2.8 KiB
Python
"""Persistence for the image update cache.
|
|
|
|
``update_service`` holds the registry-digest results in a module dict and knows
|
|
nothing about storage — it is pure registry logic and stays unit-testable
|
|
without a database. This module is its persistence half: it seeds that dict at
|
|
startup and mirrors every write back into SQLite, wired up in ``main.lifespan``.
|
|
|
|
What it buys: after a restart the update badges are there immediately instead
|
|
of blank until the next background sweep (up to an hour), and the "already
|
|
notified" marks come back with them, so a restart no longer re-announces
|
|
updates the user has already seen.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
|
|
from sqlmodel import Session, select
|
|
|
|
from database import engine
|
|
from models.runtime_state import ImageStatus
|
|
from services import update_service
|
|
|
|
logger = logging.getLogger("stackpilot.image_status")
|
|
|
|
|
|
def _to_status(row: ImageStatus) -> update_service.UpdateStatus:
|
|
return update_service.UpdateStatus(
|
|
image=row.image,
|
|
update_available=row.update_available,
|
|
current_digest=row.current_digest,
|
|
remote_digest=row.remote_digest,
|
|
checked_at=row.checked_at,
|
|
error=row.error,
|
|
local=row.local,
|
|
)
|
|
|
|
|
|
def save(status: update_service.UpdateStatus, notified: bool) -> None:
|
|
"""Upsert one image's status. Opens its own session — the caller is the
|
|
background loop, which has none."""
|
|
with Session(engine) as session:
|
|
row = session.get(ImageStatus, status.image)
|
|
if row is None:
|
|
row = ImageStatus(image=status.image)
|
|
row.update_available = status.update_available
|
|
row.current_digest = status.current_digest
|
|
row.remote_digest = status.remote_digest
|
|
row.checked_at = status.checked_at
|
|
row.error = status.error
|
|
row.local = status.local
|
|
row.notified = notified
|
|
session.add(row)
|
|
session.commit()
|
|
|
|
|
|
def install() -> int:
|
|
"""Seed the in-memory cache from the database and start mirroring writes.
|
|
|
|
Returns how many entries were restored.
|
|
"""
|
|
with Session(engine) as session:
|
|
rows = session.exec(select(ImageStatus)).all()
|
|
update_service.restore_cache([(_to_status(r), r.notified) for r in rows])
|
|
update_service.set_persist_callback(save, prune)
|
|
return len(rows)
|
|
|
|
|
|
def prune(keep: set[str]) -> int:
|
|
"""Drop rows for images that are no longer used by any stack.
|
|
|
|
Without this the table grows for the life of the install, one row per image
|
|
tag that was ever running.
|
|
"""
|
|
removed = 0
|
|
with Session(engine) as session:
|
|
for row in session.exec(select(ImageStatus)).all():
|
|
if row.image not in keep:
|
|
session.delete(row)
|
|
removed += 1
|
|
if removed:
|
|
session.commit()
|
|
return removed
|