Files
stackpilot/backend/services/gpu_service.py
T
menzeljandClaude Opus 5.5 d6cebb3371
CI / check (push) Successful in 4m9s
CI / build-and-push (push) Failing after 16m10s
Fix what a review of the whole app found, end to end (0.67.1)
A pass over every feature against a real Docker daemon, then clicking
through the UI as admin and read-only user, on a desktop and a phone.

Security. /ws/deploy ran compose up for the read-only role; it is
admin-only now. A container's inspect view, a stack's compose file
(POSTGRES_PASSWORD: hunter2) and the viewer's .env tab no longer show
credentials to that role. Git branch and URL values that git would read
as options (-x, ext::) are refused. SFTP host keys are checked: pinned
on first use or entered by hand (key line or SHA256 fingerprint), a
different key is refused before the password is sent. A backup name
from the API can no longer reach outside the destination folder. The
file browser refuses to move or rename a browse root, as delete did.

Docker lifecycle. Closing the deploy console released the stack lock
while compose was still running and logged rc=None as success; deploys
and updates are now background runs that hold the lock to the end,
report the real exit code and can be re-attached to. Every closed log
view left a `compose logs -f` behind. A dozen open tabs exhausted the
default thread pool and hung the API; event and exec streams have their
own threads. Auto-update and the update endpoint ignored failed pulls.
A deleted git stack was recreated and started by the next webhook or
poll; deleting a stack now drops its git source, auto-update policy and
schedule entries. Deleting no longer walks into mounted shares, is
refused while a backup runs, and removes the containers even when the
compose file is broken. Stack folders compose has to normalise
(Nextcloud -> nextcloud) work everywhere and group correctly on the
volumes, networks and images pages.

Detection. Host port conflicts read the container's own network
namespace; /proc/1/net is read instead. Images referenced as docker.io/…
were never update-checked; local builds no longer report "needs
credentials". NVIDIA GPUs are read from the driver's procfs. The backup
dialog's "path mismatch" warning came from mountinfo's filesystem-relative
root and fired for any stacks folder on its own disk, ZFS dataset or
btrfs subvolume; the host path now comes from Docker's mounts.

Backups and destinations. The download ignored the folder/volume
selection (axios sent binds[]). Restoring under a new name kept the old
one. A report header past nginx's buffer turned a good backup into a
502. SFTP/S3 errors were bare 500s and "Test" did not try to write.
A destination used by a schedule could be deleted. Backup file names
are in the schedule's or the browser's time zone instead of UTC.

Editor and converter. `docker run` conversion produced invalid compose
for --network host, named volumes and -dit; --gpus and --mount were
dropped; a multi-line command pasted into the one-line field became
`image: ' '` (now a textarea, and flattened continuations are read).
Validation failed for env_file stacks. The editor overwrote unsaved
edits on every container event, lost them on a stray click (now asks),
threw when closing the diff, and its helper panel listed the starter
service "app" for every existing stack. Monaco is bundled instead of
loaded from jsdelivr, so the editor works offline (and monaco-editor
0.57 drops the dompurify advisory; axios and react-router updated).

UI. All times were two hours off: offset-less UTC from SQLite was read
as local time, and "next run" always said "just now". A token refresh
mid-session duplicated deploys, reset terminals and doubled logs. A
backend restart (update, self-update) signed everyone out on reload; the
page now waits for it. The editor was unusable on a phone, tables and
tabs overflowed, dialog text was black on the dark theme, and the file
browser opened on an error with the default roots. Read-only users get
"Admin only" pages instead of 403s; in-use networks offer no delete;
"Scan all" covers StackPilot's own stacks only and runs in the
background instead of timing out at 600s.

Deployment. nginx passes the port in Host (the OIDC redirect URI lost
:5009) and keeps an outer proxy's X-Forwarded-Proto. The frontend waits
for a healthy backend (healthcheck probes every 2s while starting). The
frontend image builds with npm ci. Secrets are 0644 in a 0700 folder so
non-root containers can read them; existing files are fixed at startup.
The test suite no longer starts real containers on a host with Docker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fx7gcuy8d6nPd95g43rGHu
2026-10-15 13:51:26 +02:00

351 lines
11 KiB
Python

"""GPU detection and Compose YAML injection helpers.
Detection sources:
* NVIDIA — `nvidia-smi` query (when the toolkit is present)
* AMD/Intel — scan /dev/dri/renderD* + /sys/class/drm/*/device/vendor
"""
from __future__ import annotations
import glob
import os
import re
import subprocess
from dataclasses import asdict, dataclass
from typing import Literal, Optional
Vendor = Literal["nvidia", "amd", "intel"]
# PCI vendor IDs found in /sys/class/drm/*/device/vendor
_PCI_VENDORS = {
"0x10de": "nvidia",
"0x1002": "amd",
"0x8086": "intel",
}
@dataclass
class GPUInfo:
vendor: Vendor
index: int
name: str
uuid: Optional[str] = None
device_path: Optional[str] = None # e.g. /dev/dri/renderD128
driver: str = ""
vram_mb: Optional[int] = None
# Host group GIDs that own the DRI nodes — needed so a container can access
# a passed-through iGPU (group_add). render = renderD* node, video = card* node.
render_gid: Optional[int] = None
video_gid: Optional[int] = None
def to_dict(self) -> dict:
return asdict(self)
def _detect_nvidia() -> list[GPUInfo]:
gpus: list[GPUInfo] = []
try:
out = subprocess.run(
[
"nvidia-smi",
"--query-gpu=index,name,uuid,memory.total,driver_version",
"--format=csv,noheader,nounits",
],
capture_output=True,
text=True,
timeout=8,
)
except (FileNotFoundError, subprocess.SubprocessError):
return gpus
if out.returncode != 0:
return gpus
for line in out.stdout.strip().splitlines():
parts = [p.strip() for p in line.split(",")]
if len(parts) < 5:
continue
idx, name, uuid, mem, driver = parts[:5]
try:
index = int(idx)
except ValueError:
index = 0
try:
vram = int(float(mem))
except ValueError:
vram = None
gpus.append(
GPUInfo(
vendor="nvidia",
index=index,
name=name,
uuid=uuid,
driver=driver,
vram_mb=vram,
)
)
return gpus
def _detect_nvidia_procfs() -> list[GPUInfo]:
"""NVIDIA GPUs from the kernel driver's /proc entries.
StackPilot's image has no ``nvidia-smi`` (and the container runs without
the NVIDIA runtime), and the DRI scan below skips NVIDIA on purpose — so on
a normal deployment an NVIDIA card was never detected at all. The driver
publishes every GPU under ``/proc/driver/nvidia/gpus/<bus>/information``,
which the host /proc mount (``HOST_PROC_PATH``) makes readable here.
"""
from config import settings
for proc in (settings.HOST_PROC_PATH, "/proc"):
base = os.path.join(proc, "driver", "nvidia", "gpus")
if not os.path.isdir(base):
continue
version = _read(os.path.join(proc, "driver", "nvidia", "version"))
match = re.search(r"Kernel Module\s+([\d.]+)", version)
driver = match.group(1) if match else ""
gpus: list[GPUInfo] = []
for position, bus in enumerate(sorted(os.listdir(base))):
info: dict[str, str] = {}
for line in _read(os.path.join(base, bus, "information")).splitlines():
key, sep, value = line.partition(":")
if sep:
info[key.strip()] = value.strip()
try:
index = int(info.get("Device Minor", position))
except ValueError:
index = position
gpus.append(
GPUInfo(
vendor="nvidia",
index=index,
name=info.get("Model") or "NVIDIA GPU",
uuid=info.get("GPU UUID") or None,
driver=driver,
)
)
if gpus:
return sorted(gpus, key=lambda g: g.index)
return []
def _read(path: str) -> str:
try:
with open(path, "r", encoding="utf-8") as fh:
return fh.read().strip()
except OSError:
return ""
def _stat_gid(path: Optional[str]) -> Optional[int]:
"""Group owner (GID) of a device node — the host's GID via the /dev bind."""
if not path:
return None
try:
return os.stat(path).st_gid
except OSError:
return None
def _paired_card(render_base: str) -> Optional[str]:
"""Find the /dev/dri/cardN node that belongs to the same PCI device."""
try:
target = os.path.realpath(f"/sys/class/drm/{render_base}/device")
except OSError:
return None
for card in sorted(glob.glob("/dev/dri/card*")):
cb = os.path.basename(card)
if os.path.realpath(f"/sys/class/drm/{cb}/device") == target:
return card
return None
def _detect_dri() -> list[GPUInfo]:
"""Detect AMD/Intel render nodes via /dev/dri + sysfs."""
gpus: list[GPUInfo] = []
render_nodes = sorted(glob.glob("/dev/dri/renderD*"))
for i, node in enumerate(render_nodes):
base = os.path.basename(node) # renderD128
vendor_id = _read(f"/sys/class/drm/{base}/device/vendor").lower()
vendor = _PCI_VENDORS.get(vendor_id)
if vendor == "nvidia":
# NVIDIA is reported via nvidia-smi; skip its DRI node here.
continue
if not vendor:
continue
# Try to read a human-ish name.
device_id = _read(f"/sys/class/drm/{base}/device/device")
name = {
"amd": "AMD GPU",
"intel": "Intel iGPU",
}.get(vendor, "GPU")
if device_id:
name = f"{name} ({device_id})"
card = _paired_card(base)
gpus.append(
GPUInfo(
vendor=vendor, # type: ignore[arg-type]
index=i,
name=name,
device_path=node,
driver=vendor,
render_gid=_stat_gid(node),
video_gid=_stat_gid(card),
)
)
return gpus
def detect_gpus() -> list[GPUInfo]:
return (_detect_nvidia() or _detect_nvidia_procfs()) + _detect_dri()
def dri_group_gids() -> set[int]:
"""All render/video GIDs across detected DRI GPUs (for cleanup on remove)."""
gids: set[int] = set()
for g in _detect_dri():
if g.render_gid is not None:
gids.add(g.render_gid)
if g.video_gid is not None:
gids.add(g.video_gid)
return gids
# --------------------------------------------------------------------------- #
# Injection helpers — mutate a single service dict in place
# --------------------------------------------------------------------------- #
def inject_nvidia(
service: dict,
*,
device_ids: Optional[list[str]] = None,
count: Optional[int] = None,
capabilities: Optional[list[str]] = None,
) -> dict:
"""Add an NVIDIA device reservation under deploy.resources."""
caps = capabilities or ["gpu"]
reservation: dict = {"driver": "nvidia", "capabilities": caps}
if device_ids:
reservation["device_ids"] = device_ids
elif count is not None:
reservation["count"] = count
else:
reservation["count"] = "all"
deploy = service.setdefault("deploy", {})
resources = deploy.setdefault("resources", {})
reservations = resources.setdefault("reservations", {})
devices = reservations.setdefault("devices", [])
# Replace any existing nvidia reservation.
devices[:] = [d for d in devices if d.get("driver") != "nvidia"]
devices.append(reservation)
return service
def inject_dri(
service: dict,
*,
vendor: Vendor,
add_render_group: bool = True,
add_video_group: bool = False,
set_libva: bool = False,
render_gid: Optional[int] = None,
video_gid: Optional[int] = None,
) -> dict:
"""Pass through /dev/dri and (optionally) add render/video groups.
When the host group GIDs are known they are used as numeric ``group_add``
entries (e.g. ``"993"``) — group *names* rarely resolve inside images, so the
numeric GID is what actually grants access to a passed-through iGPU. Falls
back to the group name when the GID is unknown. For Intel QSV, set
LIBVA_DRIVER_NAME=iHD.
"""
devices = service.setdefault("devices", [])
if "/dev/dri:/dev/dri" not in devices:
devices.append("/dev/dri:/dev/dri")
groups = service.setdefault("group_add", [])
def _add(name: str, gid: Optional[int]) -> None:
value = str(gid) if gid is not None else name
existing = {str(g) for g in groups}
if value not in existing and name not in existing:
groups.append(value)
if add_render_group:
_add("render", render_gid)
if add_video_group:
_add("video", video_gid)
if set_libva and vendor == "intel":
_ensure_env(service, "LIBVA_DRIVER_NAME", "iHD")
return service
def remove_gpu(service: dict, dri_gids: Optional[set[int]] = None) -> dict:
"""Strip GPU-related config from a service.
``dri_gids`` are host render/video GIDs to also drop from ``group_add`` so
switching a service away from iGPU passthrough cleans up numeric groups too.
"""
deploy = service.get("deploy", {})
resources = deploy.get("resources", {})
reservations = resources.get("reservations", {})
if "devices" in reservations:
reservations["devices"] = [
d for d in reservations["devices"] if d.get("driver") != "nvidia"
]
if not reservations["devices"]:
reservations.pop("devices", None)
if not reservations:
resources.pop("reservations", None)
if not resources:
deploy.pop("resources", None)
if not deploy:
service.pop("deploy", None)
# DRI passthrough
if "devices" in service:
service["devices"] = [
d for d in service["devices"] if d != "/dev/dri:/dev/dri"
]
if not service["devices"]:
service.pop("devices", None)
if "group_add" in service:
strip = {"render", "video"} | {str(g) for g in (dri_gids or set())}
service["group_add"] = [
g for g in service["group_add"] if str(g) not in strip
]
if not service["group_add"]:
service.pop("group_add", None)
_remove_env(service, "LIBVA_DRIVER_NAME")
return service
def _remove_env(service: dict, key: str) -> None:
env = service.get("environment")
if isinstance(env, dict):
env.pop(key, None)
if not env:
service.pop("environment", None)
elif isinstance(env, list):
prefix = f"{key}="
service["environment"] = [
e for e in env if not (isinstance(e, str) and (e == key or e.startswith(prefix)))
]
if not service["environment"]:
service.pop("environment", None)
def _ensure_env(service: dict, key: str, value: str) -> None:
env = service.get("environment")
if env is None:
service["environment"] = [f"{key}={value}"]
return
if isinstance(env, dict):
env[key] = value
return
# list form
prefix = f"{key}="
env = [e for e in env if not (isinstance(e, str) and e.startswith(prefix))]
env.append(f"{key}={value}")
service["environment"] = env