A pass over every feature against a real Docker daemon, then clicking through the UI as admin and read-only user, on a desktop and a phone. Security. /ws/deploy ran compose up for the read-only role; it is admin-only now. A container's inspect view, a stack's compose file (POSTGRES_PASSWORD: hunter2) and the viewer's .env tab no longer show credentials to that role. Git branch and URL values that git would read as options (-x, ext::) are refused. SFTP host keys are checked: pinned on first use or entered by hand (key line or SHA256 fingerprint), a different key is refused before the password is sent. A backup name from the API can no longer reach outside the destination folder. The file browser refuses to move or rename a browse root, as delete did. Docker lifecycle. Closing the deploy console released the stack lock while compose was still running and logged rc=None as success; deploys and updates are now background runs that hold the lock to the end, report the real exit code and can be re-attached to. Every closed log view left a `compose logs -f` behind. A dozen open tabs exhausted the default thread pool and hung the API; event and exec streams have their own threads. Auto-update and the update endpoint ignored failed pulls. A deleted git stack was recreated and started by the next webhook or poll; deleting a stack now drops its git source, auto-update policy and schedule entries. Deleting no longer walks into mounted shares, is refused while a backup runs, and removes the containers even when the compose file is broken. Stack folders compose has to normalise (Nextcloud -> nextcloud) work everywhere and group correctly on the volumes, networks and images pages. Detection. Host port conflicts read the container's own network namespace; /proc/1/net is read instead. Images referenced as docker.io/… were never update-checked; local builds no longer report "needs credentials". NVIDIA GPUs are read from the driver's procfs. The backup dialog's "path mismatch" warning came from mountinfo's filesystem-relative root and fired for any stacks folder on its own disk, ZFS dataset or btrfs subvolume; the host path now comes from Docker's mounts. Backups and destinations. The download ignored the folder/volume selection (axios sent binds[]). Restoring under a new name kept the old one. A report header past nginx's buffer turned a good backup into a 502. SFTP/S3 errors were bare 500s and "Test" did not try to write. A destination used by a schedule could be deleted. Backup file names are in the schedule's or the browser's time zone instead of UTC. Editor and converter. `docker run` conversion produced invalid compose for --network host, named volumes and -dit; --gpus and --mount were dropped; a multi-line command pasted into the one-line field became `image: ' '` (now a textarea, and flattened continuations are read). Validation failed for env_file stacks. The editor overwrote unsaved edits on every container event, lost them on a stray click (now asks), threw when closing the diff, and its helper panel listed the starter service "app" for every existing stack. Monaco is bundled instead of loaded from jsdelivr, so the editor works offline (and monaco-editor 0.57 drops the dompurify advisory; axios and react-router updated). UI. All times were two hours off: offset-less UTC from SQLite was read as local time, and "next run" always said "just now". A token refresh mid-session duplicated deploys, reset terminals and doubled logs. A backend restart (update, self-update) signed everyone out on reload; the page now waits for it. The editor was unusable on a phone, tables and tabs overflowed, dialog text was black on the dark theme, and the file browser opened on an error with the default roots. Read-only users get "Admin only" pages instead of 403s; in-use networks offer no delete; "Scan all" covers StackPilot's own stacks only and runs in the background instead of timing out at 600s. Deployment. nginx passes the port in Host (the OIDC redirect URI lost :5009) and keeps an outer proxy's X-Forwarded-Proto. The frontend waits for a healthy backend (healthcheck probes every 2s while starting). The frontend image builds with npm ci. Secrets are 0644 in a 0700 folder so non-root containers can read them; existing files are fixed at startup. The test suite no longer starts real containers on a host with Docker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fx7gcuy8d6nPd95g43rGHu
164 lines
6.2 KiB
Python
164 lines
6.2 KiB
Python
"""Auto-update (Watchtower-style) orchestration.
|
|
|
|
Runs once per image-update-check cycle (called from
|
|
``update_service.background_loop`` so it reuses the freshly-populated digest
|
|
cache). For each enabled policy whose stack has a newer image available, either
|
|
pulls + redeploys the stack or just notifies, recording the outcome.
|
|
|
|
Image resolution and digest comparison live in ``update_service``; this module
|
|
adds the policy layer on top.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
from datetime import datetime, timezone
|
|
|
|
from sqlmodel import Session, select
|
|
|
|
from database import engine
|
|
from models.auto_update import AutoUpdate
|
|
from models.setting import EVENT_PULL_FAILED, EVENT_STACK_AUTO_UPDATED
|
|
from services import (
|
|
compose_service,
|
|
notify_service,
|
|
stack_lock_service,
|
|
update_service,
|
|
)
|
|
|
|
logger = logging.getLogger("stackpilot.autoupdate")
|
|
|
|
# Stack states we'll act on. We never auto-start a stopped stack.
|
|
_LIVE_STATES = {"running", "partial", "updating"}
|
|
|
|
|
|
def _now() -> datetime:
|
|
return datetime.now(timezone.utc)
|
|
|
|
|
|
# --------------------------------------------------------------------------- #
|
|
# Policy CRUD helpers
|
|
# --------------------------------------------------------------------------- #
|
|
|
|
|
|
def get_policy(session: Session, stack_id: str) -> AutoUpdate | None:
|
|
return session.exec(select(AutoUpdate).where(AutoUpdate.stack_id == stack_id)).first()
|
|
|
|
|
|
def upsert_policy(session: Session, stack_id: str, enabled: bool, redeploy: bool) -> AutoUpdate:
|
|
policy = get_policy(session, stack_id)
|
|
if policy is None:
|
|
policy = AutoUpdate(stack_id=stack_id)
|
|
policy.enabled = enabled
|
|
policy.redeploy = redeploy
|
|
session.add(policy)
|
|
session.commit()
|
|
session.refresh(policy)
|
|
return policy
|
|
|
|
|
|
def to_read(policy: AutoUpdate | None, stack_id: str) -> dict:
|
|
"""Build an AutoUpdateRead-shaped dict, defaulting to disabled when absent."""
|
|
if policy is None:
|
|
return {
|
|
"id": None, "stack_id": stack_id,
|
|
"enabled": False, "redeploy": True,
|
|
"last_run": None, "last_status": None, "last_result": None,
|
|
}
|
|
return {
|
|
"id": policy.id, "stack_id": policy.stack_id,
|
|
"enabled": policy.enabled, "redeploy": policy.redeploy,
|
|
"last_run": policy.last_run, "last_status": policy.last_status,
|
|
"last_result": policy.last_result,
|
|
}
|
|
|
|
|
|
def _record(session: Session, policy: AutoUpdate, status: str, result: str = "") -> None:
|
|
policy.last_run = _now()
|
|
policy.last_status = status
|
|
policy.last_result = result[:300] if result else None
|
|
session.add(policy)
|
|
session.commit()
|
|
|
|
|
|
async def _run_local(session: Session, policy: AutoUpdate) -> None:
|
|
stack_id = policy.stack_id
|
|
try:
|
|
state = compose_service.compute_status(stack_id)
|
|
except Exception: # noqa: BLE001
|
|
state = "unknown"
|
|
if state not in _LIVE_STATES:
|
|
_record(session, policy, "skipped", f"stack not running ({state})")
|
|
return
|
|
|
|
summary = await update_service.stack_updates(stack_id, refresh=False)
|
|
if not summary["update_available"]:
|
|
_record(session, policy, "up-to-date")
|
|
return
|
|
|
|
stale = ", ".join(summary["stale_images"])
|
|
prev = policy.last_status
|
|
if policy.redeploy:
|
|
try:
|
|
# Never redeploy underneath somebody: if a user is mid-deploy on
|
|
# this stack, skip and pick it up next cycle rather than racing
|
|
# them over the same containers.
|
|
with stack_lock_service.hold(session, stack_id, "auto-update", "auto-update"):
|
|
# pull + up, stopping at a failed pull. The exit codes used to
|
|
# be ignored entirely: a registry outage or a failing `up` was
|
|
# recorded as "updated" and announced as a success.
|
|
result = await compose_service.update(stack_id)
|
|
if result.get("returncode") != 0:
|
|
raise RuntimeError(_failure(result))
|
|
except stack_lock_service.StackBusy as exc:
|
|
_record(session, policy, "skipped", str(exc))
|
|
return
|
|
except Exception as exc: # noqa: BLE001
|
|
_record(session, policy, "error", str(exc))
|
|
await _safe_notify(EVENT_PULL_FAILED, f"Auto-update of '{stack_id}' failed", str(exc), session)
|
|
return
|
|
update_service.refresh_stack_local(stack_id)
|
|
_record(session, policy, "updated", stale)
|
|
await _safe_notify(
|
|
EVENT_STACK_AUTO_UPDATED, f"Stack '{stack_id}' auto-updated",
|
|
f"Pulled and redeployed: {stale}.", session,
|
|
)
|
|
else:
|
|
_record(session, policy, "update-available", stale)
|
|
if prev != "update-available": # notify once per transition, not every cycle
|
|
await _safe_notify(
|
|
EVENT_STACK_AUTO_UPDATED, f"Update available for '{stack_id}'",
|
|
f"Newer images: {stale} (auto-redeploy is off).", session,
|
|
)
|
|
|
|
|
|
def _failure(result: dict) -> str:
|
|
"""The last meaningful line of a failed compose run."""
|
|
text = (result.get("stderr") or result.get("stdout") or "").strip()
|
|
tail = text.splitlines()[-1] if text else ""
|
|
return f"compose exited with {result.get('returncode')}" + (f": {tail}" if tail else "")
|
|
|
|
|
|
async def _safe_notify(event: str, title: str, message: str, session: Session) -> None:
|
|
try:
|
|
await notify_service.notify(event, title, message, session)
|
|
except Exception as exc: # noqa: BLE001 - notifications are best-effort
|
|
logger.debug("auto-update notify failed: %s", exc)
|
|
|
|
|
|
async def run_policy(session: Session, policy: AutoUpdate) -> None:
|
|
await _run_local(session, policy)
|
|
|
|
|
|
async def run_due() -> None:
|
|
"""Process every enabled policy. Best-effort: one failure never aborts the rest."""
|
|
with Session(engine) as session:
|
|
policies = list(session.exec(select(AutoUpdate).where(AutoUpdate.enabled == True))) # noqa: E712
|
|
for policy in policies:
|
|
try:
|
|
with Session(engine) as session:
|
|
fresh = session.get(AutoUpdate, policy.id)
|
|
if fresh and fresh.enabled:
|
|
await run_policy(session, fresh)
|
|
except Exception as exc: # noqa: BLE001
|
|
logger.warning("Auto-update policy %s failed: %s", policy.id, exc)
|