menzeljandClaude Opus 5.5
d6cebb3371
A pass over every feature against a real Docker daemon, then clicking through the UI as admin and read-only user, on a desktop and a phone. Security. /ws/deploy ran compose up for the read-only role; it is admin-only now. A container's inspect view, a stack's compose file (POSTGRES_PASSWORD: hunter2) and the viewer's .env tab no longer show credentials to that role. Git branch and URL values that git would read as options (-x, ext::) are refused. SFTP host keys are checked: pinned on first use or entered by hand (key line or SHA256 fingerprint), a different key is refused before the password is sent. A backup name from the API can no longer reach outside the destination folder. The file browser refuses to move or rename a browse root, as delete did. Docker lifecycle. Closing the deploy console released the stack lock while compose was still running and logged rc=None as success; deploys and updates are now background runs that hold the lock to the end, report the real exit code and can be re-attached to. Every closed log view left a `compose logs -f` behind. A dozen open tabs exhausted the default thread pool and hung the API; event and exec streams have their own threads. Auto-update and the update endpoint ignored failed pulls. A deleted git stack was recreated and started by the next webhook or poll; deleting a stack now drops its git source, auto-update policy and schedule entries. Deleting no longer walks into mounted shares, is refused while a backup runs, and removes the containers even when the compose file is broken. Stack folders compose has to normalise (Nextcloud -> nextcloud) work everywhere and group correctly on the volumes, networks and images pages. Detection. Host port conflicts read the container's own network namespace; /proc/1/net is read instead. Images referenced as docker.io/… were never update-checked; local builds no longer report "needs credentials". NVIDIA GPUs are read from the driver's procfs. The backup dialog's "path mismatch" warning came from mountinfo's filesystem-relative root and fired for any stacks folder on its own disk, ZFS dataset or btrfs subvolume; the host path now comes from Docker's mounts. Backups and destinations. The download ignored the folder/volume selection (axios sent binds[]). Restoring under a new name kept the old one. A report header past nginx's buffer turned a good backup into a 502. SFTP/S3 errors were bare 500s and "Test" did not try to write. A destination used by a schedule could be deleted. Backup file names are in the schedule's or the browser's time zone instead of UTC. Editor and converter. `docker run` conversion produced invalid compose for --network host, named volumes and -dit; --gpus and --mount were dropped; a multi-line command pasted into the one-line field became `image: ' '` (now a textarea, and flattened continuations are read). Validation failed for env_file stacks. The editor overwrote unsaved edits on every container event, lost them on a stray click (now asks), threw when closing the diff, and its helper panel listed the starter service "app" for every existing stack. Monaco is bundled instead of loaded from jsdelivr, so the editor works offline (and monaco-editor 0.57 drops the dompurify advisory; axios and react-router updated). UI. All times were two hours off: offset-less UTC from SQLite was read as local time, and "next run" always said "just now". A token refresh mid-session duplicated deploys, reset terminals and doubled logs. A backend restart (update, self-update) signed everyone out on reload; the page now waits for it. The editor was unusable on a phone, tables and tabs overflowed, dialog text was black on the dark theme, and the file browser opened on an error with the default roots. Read-only users get "Admin only" pages instead of 403s; in-use networks offer no delete; "Scan all" covers StackPilot's own stacks only and runs in the background instead of timing out at 600s. Deployment. nginx passes the port in Host (the OIDC redirect URI lost :5009) and keeps an outer proxy's X-Forwarded-Proto. The frontend waits for a healthy backend (healthcheck probes every 2s while starting). The frontend image builds with npm ci. Secrets are 0644 in a 0700 folder so non-root containers can read them; existing files are fixed at startup. The test suite no longer starts real containers on a host with Docker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fx7gcuy8d6nPd95g43rGHu
124 lines
4.4 KiB
Python
124 lines
4.4 KiB
Python
"""Image references, compose project names and published ports.
|
|
|
|
Small parsers with large consequences:
|
|
|
|
* ``docker.io/library/postgres`` is how many compose files name an image, and
|
|
https://docker.io/v2/ is not a registry — so every such image sat at "could
|
|
not reach registry" forever and an update never showed up.
|
|
* compose refuses ``-p`` with anything but ``[a-z0-9_-]``, so a stack folder
|
|
found on disk as ``Nextcloud`` could not be started, stopped or deleted.
|
|
* the host's listening ports live in the host's network namespace, which
|
|
``/proc/net`` read from inside the container is not.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"image, expected",
|
|
[
|
|
("nginx", ("registry-1.docker.io", "library/nginx", "latest")),
|
|
("docker.io/nginx:1", ("registry-1.docker.io", "library/nginx", "1")),
|
|
("docker.io/library/postgres:16", ("registry-1.docker.io", "library/postgres", "16")),
|
|
("index.docker.io/foo/bar:2", ("registry-1.docker.io", "foo/bar", "2")),
|
|
("ghcr.io/a/b:1@sha256:abc", ("ghcr.io", "a/b", "sha256:abc")),
|
|
("localhost:5000/x", ("localhost:5000", "x", "latest")),
|
|
("registry.example:5000/a/b:tag", ("registry.example:5000", "a/b", "tag")),
|
|
],
|
|
)
|
|
def test_parse_ref(image, expected):
|
|
from services.update_service import parse_ref
|
|
|
|
assert parse_ref(image) == expected
|
|
|
|
|
|
def test_the_local_digest_is_the_one_for_this_repository(monkeypatch):
|
|
"""An image pulled under two names carries a digest per repository."""
|
|
from services import update_service
|
|
|
|
class Image:
|
|
attrs = {"RepoDigests": [
|
|
"lscr.io/linuxserver/radarr@sha256:aaa",
|
|
"linuxserver/radarr@sha256:bbb",
|
|
]}
|
|
|
|
class Images:
|
|
def get(self, name):
|
|
return Image()
|
|
|
|
class Client:
|
|
images = Images()
|
|
|
|
monkeypatch.setattr(update_service, "get_client", lambda: Client())
|
|
assert update_service._local_digest("linuxserver/radarr:latest") == "sha256:bbb"
|
|
assert update_service._local_digest("lscr.io/linuxserver/radarr:latest") == "sha256:aaa"
|
|
assert update_service._local_digest("docker.io/linuxserver/radarr") == "sha256:bbb"
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"stack_id, project",
|
|
[
|
|
("immich", "immich"),
|
|
("arr_stack-2", "arr_stack-2"),
|
|
("Nextcloud", "nextcloud"),
|
|
("my.app", "myapp"),
|
|
("_hidden-ish", "hidden-ish"),
|
|
("...", "stack"),
|
|
],
|
|
)
|
|
def test_project_name_matches_compose(stack_id, project):
|
|
from services.compose_service import project_name
|
|
|
|
assert project_name(stack_id) == project
|
|
|
|
|
|
def test_compose_is_called_with_the_normalised_project():
|
|
from services import compose_service
|
|
|
|
cmd = compose_service._compose_base_cmd("Nextcloud")
|
|
assert cmd[cmd.index("-p") + 1] == "nextcloud"
|
|
|
|
|
|
def test_published_ports_including_ranges_and_long_syntax():
|
|
from services.port_service import parse_compose_ports
|
|
|
|
ports = parse_compose_ports(
|
|
"services:\n a:\n ports:\n"
|
|
' - "8080:80"\n'
|
|
' - "127.0.0.1:9000:9000/udp"\n'
|
|
' - "7000-7002:7000-7002"\n'
|
|
' - "80"\n'
|
|
' - {target: 80, published: "8443"}\n'
|
|
' - "[::1]:5353:53/udp"\n'
|
|
)
|
|
assert [(p["host_port"], p["protocol"]) for p in ports] == [
|
|
(8080, "tcp"), (9000, "udp"), (7000, "tcp"), (7001, "tcp"), (7002, "tcp"),
|
|
(8443, "tcp"), (5353, "udp"),
|
|
]
|
|
|
|
|
|
def test_garbage_compose_yields_no_ports():
|
|
from services.port_service import parse_compose_ports
|
|
|
|
assert parse_compose_ports("just a string") == []
|
|
assert parse_compose_ports("services: [1, 2]") == []
|
|
assert parse_compose_ports(": : :") == []
|
|
|
|
|
|
def test_host_ports_are_read_from_the_hosts_namespace(tmp_path, monkeypatch):
|
|
"""/proc/net is self/net; PID 1 of the host /proc is the host's namespace."""
|
|
from config import settings
|
|
from services import port_service
|
|
|
|
(tmp_path / "net").mkdir()
|
|
(tmp_path / "1" / "net").mkdir(parents=True)
|
|
header = " sl local_address rem_address st\n"
|
|
# The container's own table: just its API port.
|
|
(tmp_path / "net" / "tcp").write_text(header + " 0: 00000000:1390 00000000:0000 0A\n")
|
|
# The host's: ssh on 22 (0x16).
|
|
(tmp_path / "1" / "net" / "tcp").write_text(header + " 0: 00000000:0016 00000000:0000 0A\n")
|
|
monkeypatch.setattr(settings, "HOST_PROC_PATH", str(tmp_path))
|
|
|
|
assert port_service._read_proc_net("tcp") == {22}
|