menzeljandClaude Opus 5.5
d6cebb3371
A pass over every feature against a real Docker daemon, then clicking through the UI as admin and read-only user, on a desktop and a phone. Security. /ws/deploy ran compose up for the read-only role; it is admin-only now. A container's inspect view, a stack's compose file (POSTGRES_PASSWORD: hunter2) and the viewer's .env tab no longer show credentials to that role. Git branch and URL values that git would read as options (-x, ext::) are refused. SFTP host keys are checked: pinned on first use or entered by hand (key line or SHA256 fingerprint), a different key is refused before the password is sent. A backup name from the API can no longer reach outside the destination folder. The file browser refuses to move or rename a browse root, as delete did. Docker lifecycle. Closing the deploy console released the stack lock while compose was still running and logged rc=None as success; deploys and updates are now background runs that hold the lock to the end, report the real exit code and can be re-attached to. Every closed log view left a `compose logs -f` behind. A dozen open tabs exhausted the default thread pool and hung the API; event and exec streams have their own threads. Auto-update and the update endpoint ignored failed pulls. A deleted git stack was recreated and started by the next webhook or poll; deleting a stack now drops its git source, auto-update policy and schedule entries. Deleting no longer walks into mounted shares, is refused while a backup runs, and removes the containers even when the compose file is broken. Stack folders compose has to normalise (Nextcloud -> nextcloud) work everywhere and group correctly on the volumes, networks and images pages. Detection. Host port conflicts read the container's own network namespace; /proc/1/net is read instead. Images referenced as docker.io/… were never update-checked; local builds no longer report "needs credentials". NVIDIA GPUs are read from the driver's procfs. The backup dialog's "path mismatch" warning came from mountinfo's filesystem-relative root and fired for any stacks folder on its own disk, ZFS dataset or btrfs subvolume; the host path now comes from Docker's mounts. Backups and destinations. The download ignored the folder/volume selection (axios sent binds[]). Restoring under a new name kept the old one. A report header past nginx's buffer turned a good backup into a 502. SFTP/S3 errors were bare 500s and "Test" did not try to write. A destination used by a schedule could be deleted. Backup file names are in the schedule's or the browser's time zone instead of UTC. Editor and converter. `docker run` conversion produced invalid compose for --network host, named volumes and -dit; --gpus and --mount were dropped; a multi-line command pasted into the one-line field became `image: ' '` (now a textarea, and flattened continuations are read). Validation failed for env_file stacks. The editor overwrote unsaved edits on every container event, lost them on a stray click (now asks), threw when closing the diff, and its helper panel listed the starter service "app" for every existing stack. Monaco is bundled instead of loaded from jsdelivr, so the editor works offline (and monaco-editor 0.57 drops the dompurify advisory; axios and react-router updated). UI. All times were two hours off: offset-less UTC from SQLite was read as local time, and "next run" always said "just now". A token refresh mid-session duplicated deploys, reset terminals and doubled logs. A backend restart (update, self-update) signed everyone out on reload; the page now waits for it. The editor was unusable on a phone, tables and tabs overflowed, dialog text was black on the dark theme, and the file browser opened on an error with the default roots. Read-only users get "Admin only" pages instead of 403s; in-use networks offer no delete; "Scan all" covers StackPilot's own stacks only and runs in the background instead of timing out at 600s. Deployment. nginx passes the port in Host (the OIDC redirect URI lost :5009) and keeps an outer proxy's X-Forwarded-Proto. The frontend waits for a healthy backend (healthcheck probes every 2s while starting). The frontend image builds with npm ci. Secrets are 0644 in a 0700 folder so non-root containers can read them; existing files are fixed at startup. The test suite no longer starts real containers on a host with Docker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fx7gcuy8d6nPd95g43rGHu
87 lines
3.2 KiB
Python
87 lines
3.2 KiB
Python
"""What has to go with a deleted stack, besides its containers and files.
|
|
|
|
Several features keep rows keyed by stack id, and deleting the stack used to
|
|
leave all of them behind:
|
|
|
|
* a **Git source**: the poll loop and the webhook kept syncing it — which
|
|
recreated the deleted stack's folder from the repository and, with auto
|
|
deploy on, started it again;
|
|
* an **auto-update policy**, which a new stack of the same name then silently
|
|
inherited;
|
|
* **backup schedules** naming it, which from then on failed on every run with
|
|
"stack not found" and paged somebody each time.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
|
|
from sqlmodel import Session, select
|
|
|
|
from models.auto_update import AutoUpdate
|
|
from models.backup_schedule import BackupSchedule, set_stacks, stacks_of
|
|
from models.git_source import GitSource
|
|
from services import git_service
|
|
|
|
logger = logging.getLogger("stackpilot.stack_cleanup")
|
|
|
|
|
|
def forget_stack(session: Session, stack_id: str) -> dict:
|
|
"""Drop everything that refers to ``stack_id``. The caller deletes the Stack.
|
|
|
|
A schedule that covered only this stack is disabled rather than deleted:
|
|
it may carry a destination and retention somebody wants to point at
|
|
another stack. All-stacks schedules need nothing — they resolve the stack
|
|
list when they run.
|
|
"""
|
|
report = {"git": False, "auto_update": 0, "schedules_changed": [], "schedules_disabled": []}
|
|
|
|
source = session.exec(select(GitSource).where(GitSource.stack_id == stack_id)).first()
|
|
if source is not None:
|
|
session.delete(source)
|
|
report["git"] = True
|
|
|
|
for policy in session.exec(select(AutoUpdate).where(AutoUpdate.stack_id == stack_id)).all():
|
|
session.delete(policy)
|
|
report["auto_update"] += 1
|
|
|
|
for schedule in session.exec(select(BackupSchedule)).all():
|
|
if schedule.all_stacks:
|
|
continue
|
|
ids = stacks_of(schedule)
|
|
if stack_id not in ids:
|
|
continue
|
|
remaining = [sid for sid in ids if sid != stack_id]
|
|
set_stacks(schedule, remaining)
|
|
if remaining:
|
|
report["schedules_changed"].append(schedule.id)
|
|
else:
|
|
schedule.enabled = False
|
|
schedule.last_status = f"disabled: its stack '{stack_id}' was deleted"
|
|
report["schedules_disabled"].append(schedule.id)
|
|
session.add(schedule)
|
|
|
|
session.commit()
|
|
if report["git"]:
|
|
git_service.forget(stack_id)
|
|
if any(report[k] for k in report):
|
|
logger.info("Cleaned up after deleted stack '%s': %s", stack_id, report)
|
|
return report
|
|
|
|
|
|
def prune_orphans(session: Session) -> list[str]:
|
|
"""Forget every stack that has rows here but no Stack any more.
|
|
|
|
Run at startup, after on-disk stacks have been registered: installs that
|
|
deleted stacks before this existed still carry their Git sources and
|
|
policies. Returns the stack ids cleaned up.
|
|
"""
|
|
from models.stack import Stack
|
|
|
|
known = {s.id for s in session.exec(select(Stack)).all()}
|
|
referenced = {g.stack_id for g in session.exec(select(GitSource)).all()}
|
|
referenced |= {p.stack_id for p in session.exec(select(AutoUpdate)).all()}
|
|
orphans = sorted(referenced - known)
|
|
for stack_id in orphans:
|
|
forget_stack(session, stack_id)
|
|
return orphans
|