menzeljandClaude Opus 5
60a7ccff93
The repo had no tests, no lint config, and a CI that went straight from push
to docker push. That is the reason F1 could ship: authorization lives in the
routers, each of 171 routes independently picks require_admin or
get_current_user, and nothing checked the choice was right.
670 tests, no Docker daemon needed. The app is driven through TestClient
without entering it as a context manager, which skips the lifespan — no
background loops, no socket — and conftest points DATA_DIR/STACKS_DIR at a
temp directory before anything is imported.
test_route_authorization.py is the load-bearing one. Rather than 171 implied
decisions it states the policy once — every route requires admin unless it is
listed in USER_READABLE or PUBLIC — and fails on any route that disagrees. A
new route defaults to admin, which is the safe direction; what it catches is a
route written with get_current_user that nobody weighed against "can this
return a credential". Writing the allowlist meant auditing all 53 user-readable
routes, which turned up one more leak: GET /api/templates/{id} returns a
template's env, and "save stack as template" snapshots the stack's real .env
into it. Now admin-only; the listing stays open.
test_agent_authorization.py pins the same invariant on the agent, where the
whole access model is one shared token declared per route and a single
forgotten Depends(verify_token) would hand over the host.
Both were checked by reintroducing the bug: re-opening /api/files/read fails
three tests with actionable messages, dropping a token guard fails two.
test_bundled_templates.py covers the 83 templates — parse, image per service,
.env.example in sync with what compose reads, every bind-mounted file actually
shipped, and no working default password. It found one on its first run:
authentik shipped PG_PASS=change-me and AUTHENTIK_SECRET_KEY=change-me against
a compose that marks both required, so the stack would have come up with a
known password instead of refusing to start. Fixed.
The rest ports the ad-hoc harnesses from 0.44.0 into permanent tests (crypto
round-trip incl. plaintext passthrough and key-loss handling, the browse
sandbox) and covers compose_service's slug/status/file handling and
secret_service's name validation.
ruff is configured as a floor, not a style bar: F, E9 and B only. Import
sorting is deliberately out — it is style, and enabling it would rewrite the
imports of nine files that have nothing else wrong. The 12 findings it did have
are fixed here (unused imports, an unused local, four raise-without-from that
were swallowing exception context).
CI now runs check (ruff, pytest, tsc) and only builds if it passes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Dk43rmEeRfYi5wsLDbmfyG
39 lines
1.5 KiB
TOML
39 lines
1.5 KiB
TOML
# Tooling config only — StackPilot's backend is not packaged, it runs from
|
|
# source in the image (see backend/Dockerfile). Runtime deps stay in
|
|
# requirements.txt; test/lint deps in requirements-dev.txt.
|
|
|
|
[tool.pytest.ini_options]
|
|
testpaths = ["tests"]
|
|
# Import test modules without needing tests/ to be a package, and make the
|
|
# backend root importable so `from services import ...` works the same way it
|
|
# does at runtime.
|
|
pythonpath = ["."]
|
|
addopts = "-q --strict-markers"
|
|
filterwarnings = [
|
|
# passlib 1.7.4 reads bcrypt.__about__, which bcrypt 4.x removed. Cosmetic,
|
|
# and tracked as F8 (migrate off passlib).
|
|
"ignore:.*error reading bcrypt version.*:UserWarning",
|
|
]
|
|
|
|
[tool.ruff]
|
|
target-version = "py312"
|
|
line-length = 100
|
|
exclude = ["templates"]
|
|
|
|
[tool.ruff.lint]
|
|
# Deliberately a floor, not a style bar: these are the rules that catch real
|
|
# defects (undefined names, unused imports, shadowed builtins, mutable
|
|
# defaults, swallowed exception context) without demanding a reformat of the
|
|
# existing 12k lines. Import sorting ("I") is left out on purpose — it is
|
|
# style, and turning it on would rewrite the import block of nine files that
|
|
# have nothing else wrong with them. Tighten over time rather than landing a
|
|
# big-bang cleanup.
|
|
select = ["F", "E9", "B"]
|
|
ignore = [
|
|
"B008", # Depends()/Query() in defaults is how FastAPI is written.
|
|
]
|
|
|
|
[tool.ruff.lint.per-file-ignores]
|
|
# Routers re-export request models for the agent proxy to reuse.
|
|
"routers/agents.py" = ["F401"]
|