3 Commits

Include renames

Author	SHA1	Message	Date
menzeljandClaude Opus 5.5	d6cebb3371	Fix what a review of the whole app found, end to end (0.67.1) ... A pass over every feature against a real Docker daemon, then clicking through the UI as admin and read-only user, on a desktop and a phone. Security. /ws/deploy ran compose up for the read-only role; it is admin-only now. A container's inspect view, a stack's compose file (POSTGRES_PASSWORD: hunter2) and the viewer's .env tab no longer show credentials to that role. Git branch and URL values that git would read as options (-x, ext::) are refused. SFTP host keys are checked: pinned on first use or entered by hand (key line or SHA256 fingerprint), a different key is refused before the password is sent. A backup name from the API can no longer reach outside the destination folder. The file browser refuses to move or rename a browse root, as delete did. Docker lifecycle. Closing the deploy console released the stack lock while compose was still running and logged rc=None as success; deploys and updates are now background runs that hold the lock to the end, report the real exit code and can be re-attached to. Every closed log view left a `compose logs -f` behind. A dozen open tabs exhausted the default thread pool and hung the API; event and exec streams have their own threads. Auto-update and the update endpoint ignored failed pulls. A deleted git stack was recreated and started by the next webhook or poll; deleting a stack now drops its git source, auto-update policy and schedule entries. Deleting no longer walks into mounted shares, is refused while a backup runs, and removes the containers even when the compose file is broken. Stack folders compose has to normalise (Nextcloud -> nextcloud) work everywhere and group correctly on the volumes, networks and images pages. Detection. Host port conflicts read the container's own network namespace; /proc/1/net is read instead. Images referenced as docker.io/… were never update-checked; local builds no longer report "needs credentials". NVIDIA GPUs are read from the driver's procfs. The backup dialog's "path mismatch" warning came from mountinfo's filesystem-relative root and fired for any stacks folder on its own disk, ZFS dataset or btrfs subvolume; the host path now comes from Docker's mounts. Backups and destinations. The download ignored the folder/volume selection (axios sent binds[]). Restoring under a new name kept the old one. A report header past nginx's buffer turned a good backup into a 502. SFTP/S3 errors were bare 500s and "Test" did not try to write. A destination used by a schedule could be deleted. Backup file names are in the schedule's or the browser's time zone instead of UTC. Editor and converter. `docker run` conversion produced invalid compose for --network host, named volumes and -dit; --gpus and --mount were dropped; a multi-line command pasted into the one-line field became `image: ' '` (now a textarea, and flattened continuations are read). Validation failed for env_file stacks. The editor overwrote unsaved edits on every container event, lost them on a stray click (now asks), threw when closing the diff, and its helper panel listed the starter service "app" for every existing stack. Monaco is bundled instead of loaded from jsdelivr, so the editor works offline (and monaco-editor 0.57 drops the dompurify advisory; axios and react-router updated). UI. All times were two hours off: offset-less UTC from SQLite was read as local time, and "next run" always said "just now". A token refresh mid-session duplicated deploys, reset terminals and doubled logs. A backend restart (update, self-update) signed everyone out on reload; the page now waits for it. The editor was unusable on a phone, tables and tabs overflowed, dialog text was black on the dark theme, and the file browser opened on an error with the default roots. Read-only users get "Admin only" pages instead of 403s; in-use networks offer no delete; "Scan all" covers StackPilot's own stacks only and runs in the background instead of timing out at 600s. Deployment. nginx passes the port in Host (the OIDC redirect URI lost :5009) and keeps an outer proxy's X-Forwarded-Proto. The frontend waits for a healthy backend (healthcheck probes every 2s while starting). The frontend image builds with npm ci. Secrets are 0644 in a 0700 folder so non-root containers can read them; existing files are fixed at startup. The test suite no longer starts real containers on a host with Docker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fx7gcuy8d6nPd95g43rGHu	2026-10-15 13:51:26 +02:00
menzeljandClaude Opus 5	51d1998307	Remove the remote-host (agent) integration (0.48.0) ... StackPilot now manages exactly one Docker host: the one it runs on. The stackpilot-agent sidecar and everything that proxied to it are gone — 4721 lines deleted against 657 added. Deleted outright: agent/ (image, compose, env), agent_app.py, models/agent.py, routers/agents.py (1200 lines), services/agent_service.py, the agent API client, RemoteStackDetail, the host components and AgentStacksSection. That removes 57 API routes and the three /ws/agent-* proxies. Threaded out everywhere else, which was the bulk of the work. Every API module carried an optional agentId that switched the base path; every page that listed Docker objects rendered one section per host behind a HostHeader; Files had a host switcher; the New Stack editor and the template dialog had host selectors; schedules, auto-update policies and stack summaries carried agent_id. All of it is gone, and the typechecker drove the sweep — 85 files touched, tsc and the build clean. Two things the removal exposed as dead weight rather than merely unused: compose_service kept an in-process busy set purely because the agent needed a lock and has no database. With the agent gone that was a second source of truth next to the real DB lock, so it is deleted; compute_status now reports only what the containers say and the two callers that want "updating" overlay the lock. StacksTable's linkBase prop only ever existed to point at /hosts/{id}/stacks. The dashboard's "Hosts 1/1 online" KPI can no longer say anything else, so the tile and the KPIs behind it are gone and the row is five wide. Upgrading matters here. An existing install still has an agent table holding each remote host's URL and bearer token — full Docker control of that host, sitting in the database with nothing left to use it. _drop_removed_schema drops it on first start, and drops the agent_id columns where the SQLite build supports DROP COLUMN. Each statement runs in its own transaction on purpose: a failed DDL poisons the transaction it is in, so sharing one would let an unsupported column drop take the table drop down with it. test_agent_removal covers both branches plus the fresh-install and idempotent cases, and an end-to-end run against a seeded pre-0.48 database confirms the table is gone and every /api/agents route answers 404. Docstrings that justified a design by "shared with the agent, which has no database" were rewritten rather than left lying: update_service's persistence callback and image_status_store are still the right split (registry logic stays testable without a database), but for that reason now, not the old one. The README's multi-host sections are removed and an upgrade note explains what to do with running agent containers; ROADMAP keeps its history behind a note saying the feature it describes no longer exists. CI no longer builds or pushes stackpilot-agent. 735 tests pass, ruff and tsc clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dk43rmEeRfYi5wsLDbmfyG	2026-08-31 14:11:54 +02:00
menzeljandClaude Opus 5	09bed274eb	Lock stacks during compose runs, cache stats, persist runtime state (0.47.0) ... F7 — Nothing stopped two compose operations landing on the same stack. There was a busy flag, but is_busy() was only ever read to colour the status column; no lifecycle handler consulted it before acting. Two tabs, or auto-update picking up a stack somebody had just clicked, both ran pull + up -d against the same project and raced over recreating containers. Lifecycle calls, the two deploy WebSockets and the auto-update pass now take a real lock; a second caller gets 409 (or an error frame and close 4409) and auto-update skips and retries next cycle. The lock is a row rather than a set in one worker's memory, so it holds across workers and across a restart, and it carries an expiry — a worker killed mid-deploy would otherwise strand the stack with no fix short of editing the database. F10 — /api/stacks/stats sampled every running container on every call, one blocking daemon request each, and both the dashboard and the stacks list poll it every five seconds. Two tabs on a 40-container host meant a sustained ~16 samples a second. Cached for 4s behind a lock so concurrent callers share one sweep, the same shape dashboard_service already used for its fleet aggregate. F11 — Three module dicts assumed exactly one uvicorn worker without saying so and were lost on restart. The busy set is the lock above. The image update cache is now mirrored to SQLite, so a restart shows the badges immediately instead of blanking them for up to an hour, and the already-notified marks come back with them rather than re-announcing the same updates. The login rate limiter is a table, so it cannot be cleared by getting the process to restart and no longer multiplies by the worker count. The constraint that shaped this: compose_service and update_service are shared with the agent, which has no database. Neither may import one. So the lock is a separate service the central app enforces at its own entry points, and update persistence is an opt-in callback the central app registers in its lifespan — the agent registers nothing and behaves exactly as before. A test asserts update_service never imports the database, since that is the kind of thing a later change breaks silently. Both new nets were checked by reverting the fix: dropping the lock from _lifecycle fails six tests, removing the stats cache fails the one that names the behaviour. Also wires up cache pruning in the same sweep — without it both the dict and the table grew one entry per image tag ever run, for the life of the install. 31 new tests (729 total). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dk43rmEeRfYi5wsLDbmfyG	2026-08-31 13:43:39 +02:00