Fix what a review of the whole app found, end to end (0.67.1)

A pass over every feature against a real Docker daemon, then clicking
through the UI as admin and read-only user, on a desktop and a phone.

Security. /ws/deploy ran compose up for the read-only role; it is
admin-only now. A container's inspect view, a stack's compose file
(POSTGRES_PASSWORD: hunter2) and the viewer's .env tab no longer show
credentials to that role. Git branch and URL values that git would read
as options (-x, ext::) are refused. SFTP host keys are checked: pinned
on first use or entered by hand (key line or SHA256 fingerprint), a
different key is refused before the password is sent. A backup name
from the API can no longer reach outside the destination folder. The
file browser refuses to move or rename a browse root, as delete did.

Docker lifecycle. Closing the deploy console released the stack lock
while compose was still running and logged rc=None as success; deploys
and updates are now background runs that hold the lock to the end,
report the real exit code and can be re-attached to. Every closed log
view left a `compose logs -f` behind. A dozen open tabs exhausted the
default thread pool and hung the API; event and exec streams have their
own threads. Auto-update and the update endpoint ignored failed pulls.
A deleted git stack was recreated and started by the next webhook or
poll; deleting a stack now drops its git source, auto-update policy and
schedule entries. Deleting no longer walks into mounted shares, is
refused while a backup runs, and removes the containers even when the
compose file is broken. Stack folders compose has to normalise
(Nextcloud -> nextcloud) work everywhere and group correctly on the
volumes, networks and images pages.

Detection. Host port conflicts read the container's own network
namespace; /proc/1/net is read instead. Images referenced as docker.io/…
were never update-checked; local builds no longer report "needs
credentials". NVIDIA GPUs are read from the driver's procfs. The backup
dialog's "path mismatch" warning came from mountinfo's filesystem-relative
root and fired for any stacks folder on its own disk, ZFS dataset or
btrfs subvolume; the host path now comes from Docker's mounts.

Backups and destinations. The download ignored the folder/volume
selection (axios sent binds[]). Restoring under a new name kept the old
one. A report header past nginx's buffer turned a good backup into a
502. SFTP/S3 errors were bare 500s and "Test" did not try to write.
A destination used by a schedule could be deleted. Backup file names
are in the schedule's or the browser's time zone instead of UTC.

Editor and converter. `docker run` conversion produced invalid compose
for --network host, named volumes and -dit; --gpus and --mount were
dropped; a multi-line command pasted into the one-line field became
`image: ' '` (now a textarea, and flattened continuations are read).
Validation failed for env_file stacks. The editor overwrote unsaved
edits on every container event, lost them on a stray click (now asks),
threw when closing the diff, and its helper panel listed the starter
service "app" for every existing stack. Monaco is bundled instead of
loaded from jsdelivr, so the editor works offline (and monaco-editor
0.57 drops the dompurify advisory; axios and react-router updated).

UI. All times were two hours off: offset-less UTC from SQLite was read
as local time, and "next run" always said "just now". A token refresh
mid-session duplicated deploys, reset terminals and doubled logs. A
backend restart (update, self-update) signed everyone out on reload; the
page now waits for it. The editor was unusable on a phone, tables and
tabs overflowed, dialog text was black on the dark theme, and the file
browser opened on an error with the default roots. Read-only users get
"Admin only" pages instead of 403s; in-use networks offer no delete;
"Scan all" covers StackPilot's own stacks only and runs in the
background instead of timing out at 600s.

Deployment. nginx passes the port in Host (the OIDC redirect URI lost
:5009) and keeps an outer proxy's X-Forwarded-Proto. The frontend waits
for a healthy backend (healthcheck probes every 2s while starting). The
frontend image builds with npm ci. Secrets are 0644 in a 0700 folder so
non-root containers can read them; existing files are fixed at startup.
The test suite no longer starts real containers on a host with Docker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fx7gcuy8d6nPd95g43rGHu

backend/services/update_service.py

@@ -39,6 +39,11 @@ class UpdateStatus:
     remote_digest: Optional[str]
     checked_at: float
     error: Optional[str] = None
+    #: Built on this host (``docker build``, compose ``build:``) rather than
+    #: pulled: there is no registry copy to compare against, so it is never
+    #: "out of date" — and asking Docker Hub about it only got a 401 that read
+    #: as "needs credentials".
+    local: bool = False
 
     def to_dict(self) -> dict:
         return asdict(self)
@@ -100,6 +105,14 @@ def _store(status: UpdateStatus, notified: bool) -> None:
 # --------------------------------------------------------------------------- #
 
 
+#: Docker Hub under the names people write in compose files. Only
+#: registry-1.docker.io serves the v2 API; https://docker.io/v2/ redirects to
+#: the marketing site, so a `docker.io/library/postgres` image could never be
+#: checked and sat at "could not reach registry" forever.
+_DOCKER_HUB = "registry-1.docker.io"
+_DOCKER_HUB_ALIASES = {"docker.io", "index.docker.io", "registry.docker.io", _DOCKER_HUB}
+
+
 def parse_ref(image: str) -> tuple[str, str, str]:
     """Return (registry_host, repository, tag/digest)."""
     ref = image
@@ -107,37 +120,68 @@ def parse_ref(image: str) -> tuple[str, str, str]:
     # split tag (but not the registry port colon)
     if "@" in ref:
         ref, tag = ref.split("@", 1)
-    else:
-        # find last colon after last slash
-        slash = ref.rfind("/")
-        colon = ref.rfind(":")
-        if colon > slash:
+    # find last colon after last slash. With a digest present this is the tag
+    # in "name:tag@sha256:…", which the digest outranks — but it must not stay
+    # glued to the repository name.
+    slash = ref.rfind("/")
+    colon = ref.rfind(":")
+    if colon > slash:
+        if "@" not in image:
             tag = ref[colon + 1 :]
-            ref = ref[:colon]
+        ref = ref[:colon]
 
     parts = ref.split("/", 1)
     if len(parts) == 2 and ("." in parts[0] or ":" in parts[0] or parts[0] == "localhost"):
         registry = parts[0]
         repo = parts[1]
+        if registry.lower() in _DOCKER_HUB_ALIASES:
+            registry = _DOCKER_HUB
     else:
-        registry = "registry-1.docker.io"
+        registry = _DOCKER_HUB
         repo = ref
-        if "/" not in repo:
-            repo = "library/" + repo
+    if registry == _DOCKER_HUB and "/" not in repo:
+        repo = "library/" + repo
     return registry, repo, tag
 
 
-def _local_digest(image: str) -> Optional[str]:
+def _local_attrs(image: str) -> Optional[dict]:
     try:
-        client = get_client()
-        img = safe_call(client.images.get, image)
+        return safe_call(get_client().images.get, image).attrs
     except DockerError:
         return None
-    repo_digests = img.attrs.get("RepoDigests") or []
+
+
+def _built_locally(attrs: Optional[dict]) -> bool:
+    """Whether the image came from a build on this host, not from a registry.
+
+    Docker 29+ records where an image came from (``Identity.Pull`` /
+    ``Identity.Build``). Older daemons do not; there a built image is the one
+    without RepoDigests. Unknown means "pulled" — skipping the check for a
+    pulled image would hide its updates for good.
+    """
+    if attrs is None:
+        return False
+    identity = attrs.get("Identity")
+    if isinstance(identity, dict) and identity:
+        return bool(identity.get("Build")) and not identity.get("Pull")
+    return not (attrs.get("RepoDigests") or [])
+
+
+def _local_digest(image: str, attrs: Optional[dict] = None) -> Optional[str]:
+    if attrs is None:
+        attrs = _local_attrs(image)
+    if attrs is None:
+        return None
+    repo_digests = [rd for rd in attrs.get("RepoDigests") or [] if "@" in rd]
+    # An image can carry digests for several repositories (the same image
+    # pulled as lscr.io/... and as docker.io/...); compare against the one
+    # this reference is checked against, not whichever comes first.
+    wanted = parse_ref(image)[:2]
     for rd in repo_digests:
-        if "@" in rd:
-            return rd.split("@", 1)[1]
-    return None
+        name, digest = rd.split("@", 1)
+        if parse_ref(name)[:2] == wanted:
+            return digest
+    return repo_digests[0].split("@", 1)[1] if repo_digests else None
 
 
 # --------------------------------------------------------------------------- #
@@ -236,7 +280,20 @@ async def remote_digest(image: str) -> Optional[str]:
 
 
 async def check_image(image: str) -> UpdateStatus:
-    local = _local_digest(image)
+    attrs = _local_attrs(image)
+    if _built_locally(attrs):
+        status = UpdateStatus(
+            image=image,
+            update_available=False,
+            current_digest=None,
+            remote_digest=None,
+            checked_at=time.time(),
+            local=True,
+        )
+        _NOTIFIED.discard(image)
+        _store(status, False)
+        return status
+    local = _local_digest(image, attrs)
     error = None
     try:
         remote = await remote_digest(image)
@@ -294,12 +351,15 @@ def _all_running_images() -> set[str]:
 
 def stack_images(stack_id: str) -> set[str]:
     """Images used by the containers of one compose project (== stack id)."""
+    from services.compose_service import project_name
+
+    project = project_name(stack_id)
     images: set[str] = set()
     try:
         client = get_client()
         for c in safe_call(client.containers.list, all=True):
             labels = c.labels or {}
-            if labels.get("com.docker.compose.project") != stack_id:
+            if labels.get("com.docker.compose.project") != project:
                 continue
             cfg_image = c.attrs.get("Config", {}).get("Image")
             if cfg_image:
@@ -380,6 +440,9 @@ def refresh_stack_local(stack_id: str) -> None:
         status.checked_at = time.time()
         if not status.update_available:
             _NOTIFIED.discard(image)
+        # Persisted too, or a restart brought the cleared badge back until the
+        # next background check.
+        _store(status, image in _NOTIFIED)
 
 
 async def check_all() -> dict[str, dict]: