Fix what a review of the whole app found, end to end (0.67.1)

A pass over every feature against a real Docker daemon, then clicking
through the UI as admin and read-only user, on a desktop and a phone.

Security. /ws/deploy ran compose up for the read-only role; it is
admin-only now. A container's inspect view, a stack's compose file
(POSTGRES_PASSWORD: hunter2) and the viewer's .env tab no longer show
credentials to that role. Git branch and URL values that git would read
as options (-x, ext::) are refused. SFTP host keys are checked: pinned
on first use or entered by hand (key line or SHA256 fingerprint), a
different key is refused before the password is sent. A backup name
from the API can no longer reach outside the destination folder. The
file browser refuses to move or rename a browse root, as delete did.

Docker lifecycle. Closing the deploy console released the stack lock
while compose was still running and logged rc=None as success; deploys
and updates are now background runs that hold the lock to the end,
report the real exit code and can be re-attached to. Every closed log
view left a `compose logs -f` behind. A dozen open tabs exhausted the
default thread pool and hung the API; event and exec streams have their
own threads. Auto-update and the update endpoint ignored failed pulls.
A deleted git stack was recreated and started by the next webhook or
poll; deleting a stack now drops its git source, auto-update policy and
schedule entries. Deleting no longer walks into mounted shares, is
refused while a backup runs, and removes the containers even when the
compose file is broken. Stack folders compose has to normalise
(Nextcloud -> nextcloud) work everywhere and group correctly on the
volumes, networks and images pages.

Detection. Host port conflicts read the container's own network
namespace; /proc/1/net is read instead. Images referenced as docker.io/…
were never update-checked; local builds no longer report "needs
credentials". NVIDIA GPUs are read from the driver's procfs. The backup
dialog's "path mismatch" warning came from mountinfo's filesystem-relative
root and fired for any stacks folder on its own disk, ZFS dataset or
btrfs subvolume; the host path now comes from Docker's mounts.

Backups and destinations. The download ignored the folder/volume
selection (axios sent binds[]). Restoring under a new name kept the old
one. A report header past nginx's buffer turned a good backup into a
502. SFTP/S3 errors were bare 500s and "Test" did not try to write.
A destination used by a schedule could be deleted. Backup file names
are in the schedule's or the browser's time zone instead of UTC.

Editor and converter. `docker run` conversion produced invalid compose
for --network host, named volumes and -dit; --gpus and --mount were
dropped; a multi-line command pasted into the one-line field became
`image: ' '` (now a textarea, and flattened continuations are read).
Validation failed for env_file stacks. The editor overwrote unsaved
edits on every container event, lost them on a stray click (now asks),
threw when closing the diff, and its helper panel listed the starter
service "app" for every existing stack. Monaco is bundled instead of
loaded from jsdelivr, so the editor works offline (and monaco-editor
0.57 drops the dompurify advisory; axios and react-router updated).

UI. All times were two hours off: offset-less UTC from SQLite was read
as local time, and "next run" always said "just now". A token refresh
mid-session duplicated deploys, reset terminals and doubled logs. A
backend restart (update, self-update) signed everyone out on reload; the
page now waits for it. The editor was unusable on a phone, tables and
tabs overflowed, dialog text was black on the dark theme, and the file
browser opened on an error with the default roots. Read-only users get
"Admin only" pages instead of 403s; in-use networks offer no delete;
"Scan all" covers StackPilot's own stacks only and runs in the
background instead of timing out at 600s.

Deployment. nginx passes the port in Host (the OIDC redirect URI lost
:5009) and keeps an outer proxy's X-Forwarded-Proto. The frontend waits
for a healthy backend (healthcheck probes every 2s while starting). The
frontend image builds with npm ci. Secrets are 0644 in a 0700 folder so
non-root containers can read them; existing files are fixed at startup.
The test suite no longer starts real containers on a host with Docker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fx7gcuy8d6nPd95g43rGHu

backend/services/scan_service.py

@@ -43,7 +43,7 @@ SCAN_TIMEOUT = 900.0
 #: One sweep at a time. Scanning is CPU- and IO-heavy, and two passes over the
 #: same images would just fight each other for the daemon.
 _sweep_lock = threading.Lock()
-_sweeping = {"active": False, "done": 0, "total": 0}
+_sweeping = {"active": False, "done": 0, "total": 0, "scanned": 0, "failed": 0, "run": 0}
 
 
 class ScanError(Exception):
@@ -241,15 +241,16 @@ def sweep_status() -> dict:
     return dict(_sweeping)
 
 
-async def sweep(session: Session, images: list[str]) -> dict:
-    """Scan a list of images one after another.
-
-    Deliberately serial: each scan is already CPU-hungry, and running several at
-    once on a homelab box would starve the very containers being protected.
-    """
+def _begin(total: int) -> None:
     if not _sweep_lock.acquire(blocking=False):
         raise ScanError("A scan is already running")
-    _sweeping.update({"active": True, "done": 0, "total": len(images)})
+    _sweeping.update(
+        {"active": True, "done": 0, "total": total, "scanned": 0, "failed": 0,
+         "run": _sweeping.get("run", 0) + 1}
+    )
+
+
+async def _run(session: Session, images: list[str]) -> dict:
     failed = 0
     try:
         for image in images:
@@ -262,6 +263,46 @@ async def sweep(session: Session, images: list[str]) -> dict:
                 failed += 1
             _sweeping["done"] += 1
     finally:
-        _sweeping.update({"active": False})
+        _sweeping.update({"active": False, "scanned": len(images), "failed": failed})
         _sweep_lock.release()
     return {"scanned": len(images), "failed": failed}
+
+
+async def sweep(session: Session, images: list[str]) -> dict:
+    """Scan a list of images one after another.
+
+    Deliberately serial: each scan is already CPU-hungry, and running several at
+    once on a homelab box would starve the very containers being protected.
+    """
+    _begin(len(images))
+    return await _run(session, images)
+
+
+#: Background sweeps, kept referenced until they finish.
+_tasks: set[asyncio.Task] = set()
+
+
+def start_sweep(images: list[str], on_done=None) -> dict:
+    """Start a sweep in the background and return its status at once.
+
+    A sweep over a dozen images takes far longer than the proxy waits for a
+    response (600s), so the button used to report a 504 while the scans went
+    on. Marked active before this returns, so a poll right after sees it.
+    """
+    from database import engine
+
+    _begin(len(images))
+
+    async def work() -> None:
+        with Session(engine) as session:
+            result = await _run(session, images)
+            if on_done is not None:
+                try:
+                    on_done(session, result)
+                except Exception:  # noqa: BLE001 - the sweep itself is done
+                    logger.exception("Post-sweep hook failed")
+
+    task = asyncio.create_task(work(), name="image-scan-sweep")
+    _tasks.add(task)
+    task.add_done_callback(_tasks.discard)
+    return sweep_status()