Add OIDC single sign-on, configured from Settings (0.60.0)
Authorization Code with PKCE against any provider that publishes a discovery document, configured entirely from the UI — no environment variables, no restart to fix a typo in a client id, and a Test button that fetches the provider's metadata and says what it found. The best decision here was not writing any new session machinery. The callback sets the same httpOnly refresh cookie a password login sets and redirects to "/", and the SPA's existing boot-time restore() trades it for an access token. So an SSO session *is* a normal session — same revocation, same token_version checks, same everything — and no token is ever put in a URL fragment or query string where a proxy log or the browser history would keep it. The alternative everyone reaches for first, redirecting with #access_token=..., would have been a second code path and a worse one. What is actually verified, because "the provider said so" is worth nothing otherwise: the ID token's signature against the provider's published JWKS (re-fetched once if the kid is unknown, so key rotation heals itself), issuer, audience, expiry, and a nonce minted for that specific login. The state row is deleted when it is consumed, which is what makes a replayed callback fail, and it lives in the database rather than a dict so it survives the worker restart that can happen between the redirect out and the redirect back. Accounts match on sub, not username. It is the only identifier a provider promises is stable, so somebody renamed upstream stays the same account instead of silently acquiring a second one. An existing local account with that username is linked rather than duplicated, and keeps its role — linking must not quietly demote an admin. Claim-based admin mapping works in both directions: removed from the group upstream means read-only on the next sign-in. Two things this turned up that were already broken. verify_password raised passlib's UnknownHashError on a hash it could not parse, so a password attempt against an SSO account — which stores a deliberately unusable marker — would have been a 500 rather than a 401; it now returns false for any unparseable hash, which is the right answer for a corrupt row too. And the bundled nginx never forwarded X-Forwarded-Proto, so uvicorn saw plain HTTP behind TLS: the derived redirect URI came out as http:// and the refresh cookie lost its Secure flag. Both fixed. The password form stays on the login screen no matter what. A provider outage locking you out of the machine that runs your provider is a failure mode worth designing against. The authorization matrix made me write down why three routes are public, which is the right question to be asked: they are the path by which an unauthenticated person becomes an authenticated one. status deliberately returns only a boolean and a label — no issuer, no client id — so it tells a stranger nothing the button would not. 31 tests, with a throwaway RSA key standing in for a provider so verification is exercised for real rather than mocked: wrong key under the right kid, wrong audience, wrong issuer, expired, replayed nonce, reused state. Plus an end-to-end run of the whole flow — redirect, callback, cookie, session, group-mapped admin, replay refused, password login against the SSO account cleanly refused. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -39,6 +39,19 @@ PUBLIC = {
|
||||
# Only drops the refresh cookie. Requiring a valid token would mean you
|
||||
# cannot sign out once the session has already gone stale.
|
||||
"POST /api/auth/logout",
|
||||
# Single sign-on: these three ARE the way an unauthenticated person becomes
|
||||
# an authenticated one, so none of them can sit behind a token.
|
||||
# status — says only whether SSO is on and what the button reads. No
|
||||
# issuer, no client id: nothing a stranger could not guess from
|
||||
# seeing the button itself.
|
||||
# login — mints a single-use state + PKCE verifier and redirects out.
|
||||
# callback — validates state, nonce and the ID token's signature against
|
||||
# the provider's published keys before it issues anything, and
|
||||
# hands the session back as the same httpOnly cookie a password
|
||||
# login uses rather than a token in the URL.
|
||||
"GET /api/auth/oidc/status",
|
||||
"GET /api/auth/oidc/login",
|
||||
"GET /api/auth/oidc/callback",
|
||||
# A Git forge has no StackPilot credentials to present, so this one cannot
|
||||
# be behind a bearer token. It is authorized instead by an HMAC over the
|
||||
# request body against a per-stack secret, and answers 404 — not 403 — to
|
||||
|
||||
Reference in New Issue
Block a user